Fix: Enhance code samples table with responsive design and horizontal scroll for mobile devices #1965#1966
Open
adarsh-priydarshi-5646 wants to merge 3 commits intoapache:masterfrom
Conversation
…obile responsive design ✨ Hero Section Enhancements: - Enhanced background image visibility with CSS filters (contrast 1.1, brightness 1.05, saturation 1.1) - Added subtle backdrop blur for better text readability - Improved visual hierarchy while maintaining text clarity - Enhanced button styling with proper hover effects 📱 Mobile Responsive Improvements: - Architecture section: Fixed text overflow with proper text wrapping and container constraints - Features section: Optimized text sizes and widths for all mobile devices - EndCTA section: Adjusted button sizes and text for better mobile experience - Added comprehensive breakpoint coverage (768px, 480px, 360px) 🎯 Button Enhancements: - Standardized button styling across all sections - Added proper hover effects with color transitions - Optimized button sizes for different screen sizes - Improved touch targets for mobile devices 🛠️ Technical Improvements: - Progressive text scaling for smooth responsive transitions - Proper CSS containment to prevent overflow issues - Optimized performance with efficient CSS properties - Cross-browser compatibility maintained 📊 Device Coverage: - Desktop: Enhanced background visibility and professional styling - Tablets (768px): Medium-sized optimizations - Mobile (480px): Compact layouts with readable text - Extra Small (360px): Ultra-compact designs for tiny screens All changes maintain backward compatibility and improve user experience across all devices.
…ibility - Added comprehensive responsive table styling for all device sizes - Implemented horizontal scroll functionality for small devices - Enhanced table column widths and text wrapping for better readability - Added sticky first column for context preservation during horizontal scroll - Improved table positioning and centering for desktop and large screens - Fixed text overlap issues on small devices with proper column spacing - Enabled text wrapping for Source code and Tutorial columns on mobile devices - Increased table widths to ensure all 7 columns are accessible via horizontal scroll - Added visual separators between columns for better content organization - Optimized touch scrolling experience for mobile devices - Fixed link hover effects with clean color-only changes Table now displays properly across all screen sizes: - Desktop/Large screens: All columns visible without scrolling - Tablets: Responsive layout with text ellipsis for overflow content - Mobile devices: Horizontal scroll with sticky first column and full column access
yzeng25
requested review from
Baoyuantop,
LiteSun,
SkyeYoung,
bzp2010,
guoqqqi and
juzhiyuan
Author
|
@Yilialinn Please review. |
There was a problem hiding this comment.
Pull request overview
This pull request aims to enhance the code samples table with responsive design and horizontal scroll for mobile devices to address issue #1965. However, the PR includes extensive changes well beyond its stated scope.
Changes:
- Added responsive table styling with horizontal scroll and sticky first column for mobile devices (lines 782-1334 in customTheme.scss) - the intended change
- Complete redesign of the hero section including animations, overlays, gradients, and button styling (400+ lines across hero.scss and customTheme.scss) - not mentioned in PR description
- Extensive navbar styling with dynamic behavior based on scroll position - not mentioned in PR description
- Responsive design updates to features, endcta, and architecture sections - not mentioned in PR description
- Modified plugin icon logic in plugins.tsx - not mentioned in PR description
- Removed internationalization support from Architecture component - not mentioned in PR description
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 17 comments.
Show a summary per file
| File | Description |
|---|---|
| website/src/css/customTheme.scss | Table responsive design (intended) + navbar redesign + hero section mobile overrides (unintended) |
| website/src/css/landing-sections/hero.scss | Complete hero section redesign with animations and styling overhaul (unintended) |
| website/src/css/landing-sections/features.module.scss | Added responsive breakpoints for features section (unintended) |
| website/src/css/landing-sections/endcta.module.scss | Added button styling and responsive breakpoints (unintended) |
| website/src/css/landing-sections/architecture.scss | Added responsive breakpoints and text wrapping (unintended) |
| website/src/components/sections/HeroSection.tsx | Added scroll event handler for dynamic navbar styling and removed mobile canvas check (unintended) |
| website/src/components/sections/Architecture.tsx | Removed Translate component, breaking internationalization (unintended) |
| website/src/pages/plugins.tsx | Modified plugin icon display logic (unintended) |
| website/docs/general/code-samples.md | Minor metadata improvements (intended) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
@Yilialinn I’ve been waiting for the past two months. Could you please review the PR so I can continue contributing? |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1965
Description
This PR enhances the code samples table with comprehensive responsive design and improved mobile accessibility. The changes address usability issues on small devices and provide a better user experience across all screen sizes.
Changes Made
Responsive Design Implementation
Mobile Device Enhancements
Visual Improvements
Cross-Device Compatibility
Files Modified
Before vs After
Before vs After Screenshots
Before
After
Testing