fix: remove llm related metrics for non llm requests#13088
Open
shreemaan-abhishek wants to merge 5 commits intoapache:masterfrom
Open
fix: remove llm related metrics for non llm requests#13088shreemaan-abhishek wants to merge 5 commits intoapache:masterfrom
shreemaan-abhishek wants to merge 5 commits intoapache:masterfrom
Conversation
Signed-off-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>
dosubot
bot
added
size:L
moonming
reviewed
Mar 16, 2026
Member
moonming
left a comment
moonming
left a comment
There was a problem hiding this comment.
Hi @shreemaan-abhishek, thank you for fixing the LLM metrics for non-LLM requests (#12953)!
Removing LLM-related metrics (token counts, etc.) from non-LLM requests is the correct behavior — these metrics should only be populated for AI/LLM plugin routes. I'll review the code in detail shortly.
moonming
previously approved these changes
Mar 16, 2026
Baoyuantop
previously approved these changes
Mar 17, 2026
nic-6443
reviewed
Mar 17, 2026
nic-6443
reviewed
Mar 17, 2026
t/plugin/prometheus-ai-proxy2.t
Outdated
| local body = metric_resp.body | ||
| local has_error = false | ||
| for line in string.gmatch(body, "[^\r\n]+") do | ||
| ngx.log(ngx.WARN, "dibag: ", line) |
Member
There was a problem hiding this comment.
This is a temporary debug code line that should be removed.
nic-6443
reviewed
Mar 17, 2026
Baoyuantop
added
the
wait for update
shreemaan-abhishek
dismissed stale reviews from Baoyuantop and moonming
via
ea141c9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Which issue(s) this PR fixes:
Fixes #12953
Checklist