fix(ai-request-rewrite): return 400 when request body is missing#13097
Open
sihyeonn wants to merge 1 commit intoapache:masterfrom
Open
fix(ai-request-rewrite): return 400 when request body is missing#13097sihyeonn wants to merge 1 commit intoapache:masterfrom
sihyeonn wants to merge 1 commit intoapache:masterfrom
Conversation
When the request body is nil (not an error, just empty), the access handler returns without a status code, which means the request continues through the pipeline. Downstream code then attempts to use the body, leading to unexpected errors. Return HTTP_BAD_REQUEST (400) to reject the request early, consistent with the error path just above it. Signed-off-by: Sihyeon Jang <sihyeon.jang@navercorp.com>
dosubot
bot
added
size:XS
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the
accesshandler ofai-request-rewrite, whencore.request.get_body()returnsnilwithout an error (i.e., the body is simply empty), the function returns without a status code. This causes the request to continue through the pipeline, where downstream code expectsclient_request_bodyto be present and fails with confusing errors.The fix returns
HTTP_BAD_REQUEST(400) to reject the request early, which is consistent with the error handling path directly above it (lines 190-193).Before
After