[Variant] Unshredded VariantArray producers annotate the value field as nullable (spec requires required)#10320
Draft
sdf-jkl wants to merge 2 commits into
Draft
Conversation
VariantArray producers annotate the value field as nullable (spec requires required)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes [Variant] Unshredded
VariantArrayproducers annotate thevaluefield as nullable (spec requiresrequired) #10315.let's wait till [Variant] make
valuemandatory field forVariantArray/ShreddingState#10318 shipsRationale for this change
VariantArrayto be non-nullable. Other readers might reject our impl becauseunshred_variantandvariant_get as_type Nonereturn nullable unshredded Variant.What changes are included in this PR?
valuemandatory field forVariantArray/ShreddingState#10318unshred_variantandvariant_getto return non-nullable unshredded VariantAre these changes tested?
Are there any user-facing changes?