Skip to content

[Variant] Unshredded VariantArray producers annotate the value field as nullable (spec requires required)#10320

Draft
sdf-jkl wants to merge 2 commits into
apache:mainfrom
sdf-jkl:unshredded-value-non-nullable-10315
Draft

[Variant] Unshredded VariantArray producers annotate the value field as nullable (spec requires required)#10320
sdf-jkl wants to merge 2 commits into
apache:mainfrom
sdf-jkl:unshredded-value-non-nullable-10315

Conversation

@sdf-jkl

@sdf-jkl sdf-jkl commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

  • Parquet spec required unshredded VariantArray to be non-nullable. Other readers might reject our impl because unshred_variant and variant_get as_type None return nullable unshredded Variant.

What changes are included in this PR?

Are these changes tested?

  • yes, added new unit tests and fixed some old ones

Are there any user-facing changes?

  • Yes, the nullability now conforms the spec

@github-actions github-actions Bot added parquet Changes to the parquet crate parquet-variant parquet-variant* crates labels Jul 11, 2026
@sdf-jkl sdf-jkl changed the title Unshredded value non nullable 10315 [Variant] Unshredded VariantArray producers annotate the value field as nullable (spec requires required) Jul 11, 2026
@sdf-jkl sdf-jkl changed the title [Variant] Unshredded VariantArray producers annotate the value field as nullable (spec requires required) [Variant] Unshredded VariantArray producers annotate the value field as nullable (spec requires required) Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parquet Changes to the parquet crate parquet-variant parquet-variant* crates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Variant] Unshredded VariantArray producers annotate the value field as nullable (spec requires required)

1 participant