GH-48500: [GLib][Ruby] Add ReplaceSliceOptions #48521
Merged
+248
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kou
reviewed
Dec 25, 2025
c_glib/arrow-glib/compute.cpp
Outdated
Comment on lines
7148
to
7153
| const gchar *replacement = g_value_get_string(value); | ||
| if (priv->replacement) { | ||
| g_free(priv->replacement); | ||
| } | ||
| priv->replacement = g_strdup(replacement); | ||
| options->replacement = replacement ? replacement : ""; |
Member
There was a problem hiding this comment.
Why do we need priv->replacement?
It seems that we can just use options->replacement = g_value_get_string(value).
Contributor
Author
There was a problem hiding this comment.
Thanks, that simplifies the implementation.
stenlarsson
force-pushed
the
glib-replace-slice-options
branch
from
abdf3bd to
4230f0e
Compare
github-actions
bot
added
awaiting committer review
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 14bf848. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
ReplaceSliceOptionsclass is not available in GLib/Ruby, and it is used together with theutf8_replace_slicecompute function.What changes are included in this PR?
This adds the
ReplaceSliceOptionsclass to GLib.Are these changes tested?
Yes, with Ruby unit tests.
Are there any user-facing changes?
Yes, a new class.