GH-48576: [C++][FlightRPC] ODBC: add Mac setup script #48578
+158
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added setup script for mac and platform folders Co-Authored-By: Alina (Xi) Li <[email protected]> Co-Authored-By: vic-tsang <[email protected]> Update install_odbc.sh
|
|
github-actions
bot
added
Component: C++
Component: FlightRPC
awaiting review
Contributor
Author
lidavidm
changed the title
lidavidm
reviewed
Jan 5, 2026
Member
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
Is it possible to guard the scripts with (e.g.) set -euo pipefail?
github-actions
bot
added
awaiting changes
lidavidm
reviewed
Jan 5, 2026
Comment on lines
+43
to
+47
| # Admin privilege is needed to add ODBC driver registration | ||
| if [ $EUID -ne 0 ]; then | ||
| echo "Please run this script with sudo" | ||
| exit 1 | ||
| fi |
Member
There was a problem hiding this comment.
Should we do this check up front?
| odbc_install_script="${source_dir}/install_odbc.sh" | ||
|
|
||
| chmod +x "$odbc_install_script" | ||
| . "$odbc_install_script" /Library/Apache/ArrowFlightSQLODBC/lib/libarrow_flight_sql_odbc.dylib |
Member
There was a problem hiding this comment.
Do we have to source the script?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
#48576
What changes are included in this PR?
Are these changes tested?
Will be tested in CI when PR is ready for review.
Tested locally on macOS.
Are there any user-facing changes?
N/A