GH-50581: [R] Use bundled simdjson by default#50587
Open
Reranko05 wants to merge 1 commit into
Open
Conversation
|
|
Member
|
@github-actions crossbow submit -g r |
|
Revision: 9864597 Submitted crossbow builds: ursacomputing/crossbow @ actions-357652d8fe |
Contributor
Author
|
@kou It looks like the remaining failures are related to the ongoing simdjson version discussion. If we go with requiring simdjson 4.0+ and falling back to the bundled version when the system package is too old, I think that should address this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The R build may pick up a system-installed simdjson when
simdjson_SOURCEis not explicitly set. This causes build failures in environments where the system version is incompatible or unsuitable for the build.What changes are included?
This change defaults
simdjson_SOURCEtoBUNDLEDwhen it is not already set, ensuring the R build uses the bundled simdjson by default while still allowing users to override it explicitly.This addresses the macOS CRAN release and ubuntu-r-only-r (AUTO deps) failures reported in GH-50581.
Related: #50581