feat: Use the Serde attributes and check for conflicting attributes #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
reviewed
Dec 28, 2025
Kriskras99
force-pushed
the
feat/use_serde_attributes2
branch
from
762c230 to
4efa998
Compare
This commit changes the attribute parsing in `#[derive(AvroSchema)]` to also use the Serde attributes. It will use the Serde attributes and check that they match the Avro attributes if provided. It will also check that known incompatible Serde attributes result in a compile error instead of a runtime panic. Testing for the compile errors is done using `trybuild`. These tests run only on nightly as the output can vary between compiler versions (otherwise MSRV and latest stable could have different outputs and break the entire CI).
Kriskras99
force-pushed
the
feat/use_serde_attributes2
branch
from
4efa998 to
392ae2c
Compare
Member
|
A PR has been opened at Derling repo with an example how to parse We may borrow something useful from it. |
martin-g
reviewed
Dec 31, 2025
martin-g
reviewed
Dec 31, 2025
Contributor
Author
|
I've fixed all the feedback. I've also deprecated |
martin-g
reviewed
Jan 5, 2026
Kriskras99
force-pushed
the
feat/use_serde_attributes2
branch
from
8bf46c4 to
1d802e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the attribute parsing in
#[derive(AvroSchema)]to also use the Serde attributes. It will use the Serde attributes and check that they match the Avro attributes if provided. It will also check that known incompatible Serde attributes result in a compile error instead of a runtime panic.Testing for the compile errors is done using
trybuild. These tests run only on nightly as the output can vary between compiler versions (otherwise MSRV and latest stable could have different outputs and break the entire CI).For some reason Github closed #373, not sure why. This is the exact same commit.