Skip to content

[Java Portable SDK] Configure JVM so that it exits upon OutOfMemoryError originating in JVM.#37764

Open
scwhittle wants to merge 1 commit intoapache:masterfrom
scwhittle:exit_on_oom_jvm_option
Open

[Java Portable SDK] Configure JVM so that it exits upon OutOfMemoryError originating in JVM.#37764
scwhittle wants to merge 1 commit intoapache:masterfrom
scwhittle:exit_on_oom_jvm_option

Conversation

@scwhittle
Copy link
Contributor

When ExitOnOutOfMemoryError is enabled, the JVM exits on the first occurrence of an
out-of-memory error. Use it if you prefer restarting an
instance of the JVM rather than handling out-of-memory
errors.

Note that this only handles OutOfMemoryErrors that come from within the JVM. It does not trigger when OutOfMemoryErrors are thrown from libraries, see https://bugs.openjdk.org/browse/JDK-8257790.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the Java Portable SDK by ensuring that the JVM exits gracefully when an internal OutOfMemoryError occurs. This proactive measure prevents the system from entering an unstable state, promoting a more reliable restart mechanism. Additionally, the code responsible for configuring heap dumps on OOM events has been refactored for clarity.

Highlights

  • JVM OutOfMemoryError Handling: Configured the JVM to exit immediately upon encountering an OutOfMemoryError originating within the JVM. This prevents potential corrupt states and facilitates a clean restart, as opposed to attempting to handle the error.
  • Heap Dump Configuration Refactoring: Refactored the conditional logic for enabling heap dumps on OutOfMemoryError events. This change improves code readability and maintainability without altering the existing functionality of heap dump generation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • sdks/java/container/boot.go
    • Added the -XX:+ExitOnOutOfMemory JVM argument to force an exit on internal OutOfMemoryErrors.
    • Refactored the conditional logic for appending heap dump arguments.
Activity
  • No human activity has been recorded for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@scwhittle scwhittle force-pushed the exit_on_oom_jvm_option branch from 8954cfe to cb723de Compare March 4, 2026 14:32
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Assigning reviewers:

R: @ahmedabu98 for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant