Refresh Iceberg partition specs periodically#38408
Open
AtharvUrunkar wants to merge 1 commit intoapache:masterfrom
Open
Refresh Iceberg partition specs periodically#38408AtharvUrunkar wants to merge 1 commit intoapache:masterfrom
AtharvUrunkar wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
Contributor
|
Assigning reviewers: R: @kennknowles for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #38337
This change updates
AssignDestinationsAndPartitionsto periodically refresh cached Iceberg partition specs instead of loading them only once per worker instance.Previously,
PartitionKeyandBeamRowWrapperinstances were cached indefinitely, which could result in stale partition specs being used after table spec updates.Changes
Testing
./gradlew spotlessApply./gradlew :sdks:java:io:iceberg:testNote: Local Iceberg test execution on Windows encountered unrelated environment/runtime issues (
URISyntaxException/Unsafeinitialization errors) likely tied to Windows + Java toolchain compatibility rather than this isolated change.