[CALCITE-7601] Harden ST_GeomFromGML against external entity expansion#5006
Open
alhudz wants to merge 2 commits into
Open
[CALCITE-7601] Harden ST_GeomFromGML against external entity expansion#5006alhudz wants to merge 2 commits into
alhudz wants to merge 2 commits into
Annotations
3 errors and 8 warnings
|
Test
Execution failed for task ':core:autostyleJavaCheck'.
> The following files have format violations:
src/test/java/org/apache/calcite/runtime/SpatialTypeUtilsTest.java
@@ -53,8 +53,8 @@
}
@test void testFromGml() {
-····Geometry·g·=·SpatialTypeUtils.fromGml(␊
-········"<gml:Point·xmlns:gml=\"http://www.opengis.net/gml\">"␊
+····Geometry·g·=␊
+········SpatialTypeUtils.fromGml("<gml:Point·xmlns:gml=\"http://www.opengis.net/gml\">"␊
+ "<gml:coordinates>1,2</gml:coordinates></gml:Point>");
assertThat(g.getCoordinate().getX(), is(1D));
assertThat(g.getCoordinate().getY(), is(2D));
You might want to adjust -PmaxCheckMessageLines=50
-PmaxFilesToList=10
-PminLinesPerFile=4
to see more violations
Run './gradlew autostyleApply' to fix the violations.
|
|
Test:
:core:autostyleJavaCheck#L0
Execution failed for task ':core:autostyleJavaCheck'.
Caused by:
The following files have format violations:
src/test/java/org/apache/calcite/runtime/SpatialTypeUtilsTest.java
@@ -53,8 +53,8 @@
}
@test void testFromGml() {
-····Geometry·g·=·SpatialTypeUtils.fromGml(␊
-········"<gml:Point·xmlns:gml=\"http://www.opengis.net/gml\">"␊
+····Geometry·g·=␊
+········SpatialTypeUtils.fromGml("<gml:Point·xmlns:gml=\"http://www.opengis.net/gml\">"␊
+ "<gml:coordinates>1,2</gml:coordinates></gml:Point>");
assertThat(g.getCoordinate().getX(), is(1D));
assertThat(g.getCoordinate().getY(), is(2D));
You might want to adjust -PmaxCheckMessageLines=50
-PmaxFilesToList=10
-PminLinesPerFile=4
to see more violations
Run './gradlew autostyleApply' to fix the violations.
|
|
Test:
core/src/test/java/org/apache/calcite/runtime/SpatialTypeUtilsTest.java#L56
Replace 2 lines 56..57 with
Geometry g =
SpatialTypeUtils.fromGml("<gml:Point xmlns:gml=\"http://www.opengis.net/gml\">"
|
|
Complete job
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: burrunan/gradle-cache-action@v1. Actions will be forced to run with Node.js 24 by default starting June 16th, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Post Test
Failed to save: <h2>Our services aren't available right now</h2><p>We're working to restore all services as soon as possible. Please check back soon.</p>0Gt0qagAAAACz82hdON1ITJGvW/5n0rS3UEhMMzBFREdFMDExOQBFZGdl
|
|
Post Test
Failed to save: <h2>Our services aren't available right now</h2><p>We're working to restore all services as soon as possible. Please check back soon.</p>0Gt0qagAAAADIOUINMlNvRYjKuM5JK4NrUEhMMzBFREdFMDExOQBFZGdl
|
|
Post Test
Failed to save: <h2>Our services aren't available right now</h2><p>We're working to restore all services as soon as possible. Please check back soon.</p>0DN0qagAAAAD9URugHUrDR5bq8inX6AXBUEhMMzBFREdFMDExOQBFZGdl
|
|
Test
Failed to restore: Cache service responded with 400
|
|
Test
Failed to restore: Cache service responded with 400
|
|
Test
Failed to restore: Cache service responded with 400
|
|
Test
Failed to restore: Cache service responded with 400
|
background
wait
wait-all
cancel
parallel
Loading