Skip to content

CAMEL-22972: camel-as2 - AS2ClientConnection leaks HTTP connections o… #21307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davsclaus merged 1 commit into from
Feb 8, 2026
Merged

CAMEL-22972: camel-as2 - AS2ClientConnection leaks HTTP connections o… #21307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 40 additions & 21 deletions ...2/camel-as2-api/src/main/java/org/apache/camel/component/as2/api/AS2ClientConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import org.apache.camel.component.as2.api.io.AS2BHttpClientConnection;
import org.apache.camel.component.as2.api.protocol.RequestAS2;
import org.apache.camel.component.as2.api.protocol.RequestMDN;
import org.apache.camel.util.IOHelper;
import org.apache.camel.util.ObjectHelper;
import org.apache.hc.client5.http.ConnectionKeepAliveStrategy;
import org.apache.hc.client5.http.HttpRoute;
Expand Down Expand Up @@ -187,31 +188,49 @@ public HttpResponse send(ClassicHttpRequest request, HttpCoreContext httpContext
throws HttpException, IOException, InterruptedException, ExecutionException, TimeoutException {

HttpRoute route = new HttpRoute(targetHost);

request.setAuthority(new URIAuthority(targetHost));

LeaseRequest leaseRequest = connectionPoolManager.lease(UUID.randomUUID().toString(), route, null);
ConnectionEndpoint endpoint = leaseRequest.get(Timeout.ofSeconds(RETRIEVE_CONNECTION_TIMEOUT_SECONDS));
if (!endpoint.isConnected()) {
connectionPoolManager.connect(endpoint, TimeValue.ofMilliseconds(connectionTimeoutMilliseconds), httpContext);
}

// Execute Request
HttpRequestExecutor httpExecutor = new HttpRequestExecutor() {
@Override
public ClassicHttpResponse execute(ClassicHttpRequest request, HttpClientConnection conn, HttpContext context)
throws IOException, HttpException {
super.preProcess(request, httpProcessor, context);
ClassicHttpResponse response = super.execute(request, conn, context);
super.postProcess(response, httpProcessor, context);
return response;
ConnectionEndpoint endpoint = null;
HttpResponse response = null;
try {
endpoint = leaseRequest.get(Timeout.ofSeconds(RETRIEVE_CONNECTION_TIMEOUT_SECONDS));
if (!endpoint.isConnected()) {
connectionPoolManager.connect(endpoint, TimeValue.ofMilliseconds(connectionTimeoutMilliseconds), httpContext);
}
};

HttpResponse response = endpoint.execute(UUID.randomUUID().toString(), request, httpExecutor, httpContext);
connectionPoolManager.release(endpoint, null,
connectionKeepAliveStrategy.getKeepAliveDuration(response, httpContext));

// Execute Request
HttpRequestExecutor httpExecutor = new HttpRequestExecutor() {
@Override
public ClassicHttpResponse execute(ClassicHttpRequest request, HttpClientConnection conn, HttpContext context)
throws IOException, HttpException {
super.preProcess(request, httpProcessor, context);
ClassicHttpResponse response = super.execute(request, conn, context);
super.postProcess(response, httpProcessor, context);
return response;
}
};
response = endpoint.execute(UUID.randomUUID().toString(), request, httpExecutor, httpContext);
} finally {
if (endpoint != null) {
TimeValue keepAlive = null;
if (response != null) {
// Normal happy path: release with computed keep-alive.
keepAlive = connectionKeepAliveStrategy.getKeepAliveDuration(response, httpContext);
}
if (keepAlive == null) {
// If we didn't get a response, something failed mid-flight:
// do NOT keep this connection around. Close it and release with zero keep-alive.
keepAlive = TimeValue.ZERO_MILLISECONDS;
}
try {
connectionPoolManager.release(endpoint, null, keepAlive);
} catch (Exception ignored) {
// ignore
} finally {
IOHelper.close(endpoint);
}
}
}
return response;
}

Expand Down