[NET-741] Add subnet IPv6 handling#391
Conversation
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
|
Since there hasn't been much feedback so far... I want to ask whether this approach is okay or if you prefer a different direction? cc @garydgregory or other maintainers @sebbASF ? |
|
Hey @see-quick , is there a JIRA issue for this PR? |
I'll try take a look this week... |
|
Hi, I have opened the KIP-1276 , which is currently under discussion. This change helps enable the functionality described in the KIP. I appreciate your time and feedback. |
|
The Jira ticket is https://issues.apache.org/jira/browse/NET-741 |
garydgregory
left a comment
There was a problem hiding this comment.
Hello @see-quick
I'm sorry I haven't commented here for a while.
I think it would be nice to have a test class or method that specifically tests all the examples in https://datatracker.ietf.org/doc/html/rfc5952
The Javadoc should also point to the RFC.
| return new SubnetInfo(); | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Add a Javadoc to describe the format. Is there an expectation that this string can be fed back in the constructor? Either way, testToString should test that use case.
There was a problem hiding this comment.
This is purely for debugging purposes same as IPv4 util. I have added a Javadoc to also reference getCidrSignature as such method can be used for that use case (i.e., string that can be fed back in the constructor). Also, I have extended testToString test case.
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Add a newline at the end of the file.
|
Thank you @see-quick |
This PR adds
SubnetUtils6to also support IPv6 CIDR notation, as the end user could possibly need handling not just the IPv4 stack. Moreover, I have added tests to cover this functionality accordingly.