Use hostname for FTPS EPSV data connection#395
Open
codingtim wants to merge 1 commit intoapache:masterfrom
Open
Use hostname for FTPS EPSV data connection#395codingtim wants to merge 1 commit intoapache:masterfrom
codingtim wants to merge 1 commit intoapache:masterfrom
Conversation
garydgregory
requested changes
Mar 17, 2026
| passivePort = port; | ||
| } | ||
|
|
||
| protected String _resolveExtendedPassiveModeHost() { |
Member
There was a problem hiding this comment.
Hello @codingtim ,
Please add a Javadoc with a description and an @since 3.14.0. Also, I don't think we need to continue the horror of leading underscores in method names unless we are overriding 😉
Alternatively, both methods could be package private which would avoid expanding the publicly available API footprint.
Don't forget to run 'mvn' by itself before you push to run all build checks.
This allows FTPS to reuse the TLS session of the FSTP command connection for the data connection.
codingtim
force-pushed
the
feature/ftps-epsv-tls-session-reuse
branch
from
dce4d3e to
17b41ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows FTPS to reuse the TLS session
of the FSTP command connection for the data connection.