Feat: to_json Infinity/-Infinity Nan values support#3875
Open
kazantsev-maksim wants to merge 61 commits into
Open
Feat: to_json Infinity/-Infinity Nan values support#3875kazantsev-maksim wants to merge 61 commits into
kazantsev-maksim wants to merge 61 commits into
Conversation
This reverts commit 768b3e9.
Contributor
Author
|
@kazuyukitanimura @andygrove Could you take another see when you have time. |
andygrove
reviewed
Apr 22, 2026
Comment on lines
+35
to
+37
| -- query expect_fallback(Struct type: StructType(StructField(a,ArrayType(IntegerType,false),false)) contains unsupported types) | ||
| query ignore("Need support Spark 4.0.0") | ||
| SELECT to_json(named_struct(a, array(b))) |
Member
There was a problem hiding this comment.
could you create a separate structs_to_json_spark4.sql for these tests and set min spark version 4 for that file, and change these to expect_fallback
Contributor
Author
There was a problem hiding this comment.
I updated the branch from master and updated the tests.
andygrove
reviewed
Apr 22, 2026
…support # Conflicts: # spark/src/main/scala/org/apache/comet/serde/structs.scala
Member
|
I started CI. I will review once CI has run. Thanks @kazantsev-maksim |
Contributor
Author
|
Tests using expect_fallback work incorrectly on Spark versions >= 4.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3016
Rationale for this change
What changes are included in this PR?
How are these changes tested?
Tested with existing unit tests