Fix array_except nullability mismatch#4237
Open
yuboxx wants to merge 3 commits into
Open
Conversation
yuboxx
changed the title
Contributor
Author
|
@comphead This PR should be ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3646.
Rationale for this change
Spark can produce equivalent arrays with different
containsNullvalues. DataFusion'sarray_exceptchecks Arrow list types strictly, including child field nullability, so Comet could reject compatible Spark arrays withList(Int32)vsList(non-null Int32).What changes are included in this PR?
This PR wraps DataFusion's
array_exceptUDF to normalize list child nullability before delegation, and serializes an explicit normalized return type so Comet's planned schema matches the runtime Arrow result.It also re-enables the SQL regression case and adds coverage for nested arrays and mixed-nullability inputs.
How are these changes tested?
cargo test -p datafusion-comet-spark-expr normalizes_ --lib./mvnw test -Dsuites="org.apache.comet.CometSqlFileTestSuite array_except" -Dtest=none