Skip to content

feat: support f16 in coercion logic #18944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Jefffrey wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: support f16 in coercion logic #18944

Jefffrey wants to merge 9 commits into from
+42 −3

Conversation

@Jefffrey
Copy link
Contributor

@Jefffrey Jefffrey commented Nov 26, 2025 •
edited
Loading

Which issue does this PR close?

Rationale for this change

Originally:

As pointed out by @martin-g, even though we plan to remove NUMERICS (see #18092) we should probably add f16 first so we don't conflate adding new functionality with refactoring changes.

Updated:

#19727 removes NUMERICS for us, which surfaced a bug where f16 wasn't being coerced to f64. Turns out we didn't have f16 support in the logic calculating the potential coercions. Fixing this so f16 input to a signature expected f64 is now allowed and coerced.

What changes are included in this PR?

Support coercion of f16 to f64 as specified by signature.

Add tests for regr, percentile & covar functions.

Are these changes tested?

Added tests.

Are there any user-facing changes?

No.

@github-actions github-actions bot added logical-expr Logical plan and expressions sqllogictest SQL Logic Tests (.slt) labels Nov 26, 2025
@Jefffrey Jefffrey mentioned this pull request Nov 26, 2025
Open
@github-actions github-actions bot added the optimizer Optimizer rules label Nov 26, 2025
martin-g
martin-g approved these changes Nov 26, 2025
View reviewed changes
Copy link
Member

@martin-g martin-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jefffrey Jefffrey marked this pull request as ready for review November 26, 2025 21:08
@Jefffrey Jefffrey changed the title feat: support f16 for covar, regr & percentile feat: support f16 in coercion ogic Jan 27, 2026
@Jefffrey Jefffrey changed the title feat: support f16 in coercion ogic feat: support f16 in coercion logic Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@martin-g martin-g martin-g approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

logical-expr Logical plan and expressions optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support f16 input for covariance/regr/percentile_cont

2 participants

@Jefffrey @martin-g