[branch-53] fix: HashJoin panic with String dictionary keys (don't flatten keys) (#20505)#20791
Merged
alamb merged 1 commit intoapache:branch-53from Mar 10, 2026
Merged
[branch-53] fix: HashJoin panic with String dictionary keys (don't flatten keys) (#20505)#20791alamb merged 1 commit intoapache:branch-53from
HashJoin panic with String dictionary keys (don't flatten keys) (#20505)#20791alamb merged 1 commit intoapache:branch-53from
Conversation
apache#20505) ## Which issue does this PR close? - Fixes apache#20696 - Follow on to apache#20441 ## Rationale for this change apache#20441 (review) fixes the special case DictionaryArray handling in Joins. However, I don't think we need to special case DictionaryArrays at all ## What changes are included in this PR? 1. Remove the special case dictionary handling ## Are these changes tested? Yes by CI ## Are there any user-facing changes? No (though maybe some queries get faster)
github-actions
bot
added
sqllogictest
This was referenced Mar 8, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
53.0.0(Feb 2026 / Mar 2026) #19692INNER JOINwith dictionary keys fails when run on parquet withpushdown_filters = true. #20696 on branch-53This PR:
HashJoinpanic with String dictionary keys (don't flatten keys) #20505 from @alamb to the [branch-53]