test: add skipped UPDATE ... FROM coverage for issue #19950#20800
Open
kosiew wants to merge 2 commits intoapache:mainfrom
Open
test: add skipped UPDATE ... FROM coverage for issue #19950#20800kosiew wants to merge 2 commits intoapache:mainfrom
kosiew wants to merge 2 commits intoapache:mainfrom
Conversation
Extract test cases from the original apache#20745 change set into a tests-only PR. - add skipped Rust tests for UPDATE ... FROM planning and filter extraction - add skipped SQL integration coverage for original target-row projection - preserve SQLLogicTest cases as commented-out TODO(19950) coverage - add only minimal compile-time test scaffolding, without the implementation fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
UPDATE ...FROMbug #19950Rationale for this change
#20745 contains behavioral changes with a substantial amount of new test coverage to close #19950, but has more than 1000 lines, which makes review difficult as a single PR. This PR isolates the test additions into a tests-only precursor so reviewers can evaluate the expected behavior separately from the implementation.
The intent is to land the coverage scaffolding first without changing current behavior. The newly extracted tests are intentionally skipped and annotated with TODOs referencing #19950 so they can be enabled when the implementation PR lands.
What changes are included in this PR?
This PR contains only test-side changes and the smallest compile-time scaffolding needed to carry those tests on this branch:
Extracts the new/modified tests Support
UPDATE ... FROMand preserve source-qualified assignments #20745Adds the extracted Rust tests to:
datafusion/core/tests/custom_sources_cases/dml_planning.rsdatafusion/core/src/physical_planner.rstest moduledatafusion/sql/tests/sql_integration.rsMarks the extracted Rust tests as skipped with:
#[ignore = "TODO(19950): enable once the implementation PR lands"]Adds
TODO(19950)comments to each skipped Rust test.Preserves the extracted SQLLogicTest coverage in:
as commented-out skipped cases with
TODO(19950)markers so the intended scenarios are present in the branch without being executed.Adds only minimal test-support scaffolding:
physical_planner.rsphysical_planner.rsso the extracted planner tests compile against the current branch shapeNo implementation fix for
UPDATE ... FROMis included here.Are these changes tested?
Yes, the branch was verified to build with the newly added skipped tests in place using no-run test builds:
The newly extracted tests are intentionally skipped in this PR, so they compile but do not run until the implementation PR lands.
Are there any user-facing changes?
No. This PR is tests-only in intent and does not change existing runtime behavior.
LLM-generated code disclosure
This PR includes LLM-generated code and comments. All LLM-generated content has been manually reviewed and tested.