Open
Conversation
github-actions
bot
added
documentation
Author
|
Should regex flags be added as a 4th (optional) argument? |
Contributor
Omega359
reviewed
Mar 9, 2026
| pattern_opts: &impl StringArrayType<'b>, | ||
| idx_opts: &Int64Array, | ||
| ) -> Result<ArrayRef> { | ||
| let mut results = GenericStringBuilder::<OffsetSize>::new(); |
Contributor
There was a problem hiding this comment.
Related to #20585 perhaps pass in a StringLikeArrayBuilder instead of forcing the return object to utf8/largeutf8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
No particular reason. This PR was done as an exercise.
What changes are included in this PR?
Implements the
regexp_extractfunction from pyspark:https://spark.apache.org/docs/latest/api/python/reference/pyspark.sql/api/pyspark.sql.functions.regexp_extract.html
Are these changes tested?
Tested in
regexp_extract.slt.Are there any user-facing changes?
Yes, a new UDF is made available to the user.