feat: suport spark compatible floor function#20860
feat: suport spark compatible floor function#20860coderfender wants to merge 2 commits intoapache:mainfrom
Conversation
|
Is this a duplicate of #20594? Test suite here looks more comprehensive, maybe @shivbhatia10 might like to take a look? |
|
@xanderbailey Yeah , I initially though since @shivbhatia10 implemented ceil function , I would go for other math function but turns out we have 4 pending PRs from his side and I started reviewing his implementations to help the effort and take one for the team :) |
|
@xanderbailey left review as well #20593 |
| DataType::Float32 | DataType::Float64 => DataType::Int64, | ||
| DataType::Int8 | DataType::Int16 | DataType::Int32 | DataType::Int64 => { | ||
| DataType::Int64 | ||
| } |
There was a problem hiding this comment.
| DataType::Float32 | DataType::Float64 => DataType::Int64, | |
| DataType::Int8 | DataType::Int16 | DataType::Int32 | DataType::Int64 => { | |
| DataType::Int64 | |
| } | |
| DataType::Float32 | DataType::Float64 | DataType::Int8 | DataType::Int16 | DataType::Int32 | DataType::Int64 => { | |
| DataType::Int64 | |
| } |
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { |
There was a problem hiding this comment.
Could we move all these tests to SLTs?
|
Sounds good to me @Jefffrey . I will rebase this PR and add more tests to this PR |
|
@coderfender I can work on this if its okay |
|
Sure ! Always happy to get help on this. Please tag me once you have the PR up . Thank you |
|
Hey @coderfender @athlcode sorry about blocking this one with my other PR, I missed that this already existed - I've closed that one, I don't have the bandwidth to work on it at the moment |
|
@coderfender I have the PR up with the comments resolved as well: #21933 |
5 participants
Which issue does this PR close?
Part of #15914
Rationale for this change
Spark compatible semantics for
floorfunctionWhat changes are included in this PR?
Implements SparkFloor UDF with Spark-compatible return types:
Are these changes tested?
Yes . Added unit tests and SLT tests
Are there any user-facing changes?