Skip to content

ci: add auto detected api change label on breaking change detecting in the CI#21953

Open
rluvaton wants to merge 4 commits intoapache:mainfrom
rluvaton:add-label-on-api-change
Open

ci: add auto detected api change label on breaking change detecting in the CI#21953
rluvaton wants to merge 4 commits intoapache:mainfrom
rluvaton:add-label-on-api-change

Conversation

@rluvaton
Copy link
Copy Markdown
Member

@rluvaton rluvaton commented Apr 30, 2026

before merging this PR, the label auto detected api change should be created

Which issue does this PR close?

Rationale for this change

Without label the releaser and the people who write the change log in a new release won't find this using the regular
generate-changelog.py script and not using the existing api change label as described in the issue and in the workflow comment

What changes are included in this PR?

image

Are these changes tested?

No

Are there any user-facing changes?

No

@github-actions github-actions Bot added the development-process Related to development process of DataFusion label Apr 30, 2026
Copy link
Copy Markdown
Member

@asolimando asolimando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is extremely cool, a big step forward to the automation of release notes for breaking changes, which are generally a nightmare to track in OSS with lots of side-effects on end-users, I wish any project had that detection + labeling machinery!

@rluvaton
Copy link
Copy Markdown
Member Author

rluvaton commented May 3, 2026

@kumarUjjawal can you please review?

@kumarUjjawal
Copy link
Copy Markdown
Contributor

Per my understanding this adds the new auto detected api change label, but the changelog script does not use it yet. So a PR with only this new label may still be missing from the breaking changes section in release notes.

we should also update the changelog script to treat auto detected api change the same as api change?

@rluvaton
Copy link
Copy Markdown
Member Author

rluvaton commented May 3, 2026

yes, updated

Copy link
Copy Markdown
Contributor

@kumarUjjawal kumarUjjawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will have to create the label before merging this.

@rluvaton
Copy link
Copy Markdown
Member Author

rluvaton commented May 4, 2026

@Jefffrey @alamb @comphead can one of you create the label auto detected api change before merging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Breaking change detector: adding "auto detect api change" label on detection

3 participants