Respect DATA_DIR location for sql benchmarks#21961
Open
Omega359 wants to merge 1 commit intoapache:mainfrom
Open
Respect DATA_DIR location for sql benchmarks#21961Omega359 wants to merge 1 commit intoapache:mainfrom
Omega359 wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
@adriangb fyi. I know you changed your benchmark runner already but for the future... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Currently if DATA_DIR is set for bench.sh it is not respected for sql benchmarks and defaults to benchmarks/data
What changes are included in this PR?
Updated tpch benchmarks to respect DATA_DIR defaulting to 'data' (in benchmarks/)
Are these changes tested?
Yes, unit test + manual testing.
Are there any user-facing changes?
No.