Parquet row filter struct access tree#23217
Open
SubhamSinghal wants to merge 2 commits into
Open
Conversation
kosiew
approved these changes
Jun 29, 2026
Contributor
There was a problem hiding this comment.
@SubhamSinghal
Thanks!
This LGTM. I have one small non-blocking suggestion for future cleanup.
|
|
||
| let pruned_data_type = prune_struct_type(field.data_type(), field_paths); | ||
| let pruned_data_type = prune_struct_type(field.data_type(), node); | ||
| Arc::new(Field::new( |
Contributor
There was a problem hiding this comment.
Small future cleanup suggestion: if this internal projected schema is expected to preserve wrapper field metadata for pruned structs, it might be worth copying the metadata when rebuilding the root and intermediate Fields here and in prune_struct_type.
I don't think this PR introduces the issue, and it probably is not scan output visible since the terminal fields are cloned and the decoder projection can restore the requested output schema. This is mostly a future proofing and test coverage suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Are these changes tested?
Yes
Are there any user-facing changes?
No. This is an internal refactor