fix: infer LIMIT and OFFSET placeholder parameter types#23260
Open
Probablism wants to merge 1 commit into
Open
fix: infer LIMIT and OFFSET placeholder parameter types#23260Probablism wants to merge 1 commit into
Probablism wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
LIMITclause #15978.Rationale for this change
Bare placeholders used as
LIMITorOFFSETrow-count expressions currently remain untyped inLogicalPlan::get_parameter_types(). DataFusion already coerces LIMIT/OFFSET row counts toInt64during analysis, so the metadata APIs should report the same type for bare row-count placeholders.What changes are included in this PR?
Int64parameter fields for bare unresolved placeholders used directly asLIMITorOFFSETexpressions.Are these changes tested?
Yes:
cargo fmt --all -- --checkcargo test -p datafusion-expr test_limit_cargo test -p datafusion-sql --test sql_integration test_infer_types_from_limitcargo test -p datafusion-sql --test sql_integration test_prepare_statement_infer_types_from_limitcargo test -p datafusioncargo test -p datafusion-clicargo test --profile=ci --test sqllogictests./dev/rust_lint.shAre there any user-facing changes?
Yes.
LogicalPlan::get_parameter_types()andLogicalPlan::get_parameter_fields()now reportInt64for bare placeholders used directly inLIMITandOFFSET. There are no breaking API changes.