Skip to content

branch-4.1: [fix](file-cache) Make sync clear use safe removal #64578#64692

Merged
yiguolei merged 1 commit into
branch-4.1from
auto-pick-64578-branch-4.1
Jun 23, 2026
Merged

branch-4.1: [fix](file-cache) Make sync clear use safe removal #64578#64692
yiguolei merged 1 commit into
branch-4.1from
auto-pick-64578-branch-4.1

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Cherry-picked from #64578

### What
- Replace sync clear direct storage wipe with the safe block scan/remove
path.
- Keep busy blocks on holder lifecycle and synchronously remove
releasable downloaded blocks.
- Reject concurrent sync clear requests with HTTP 400.
- Add large sync-clear and concurrent-clear BE tests with SyncPoint
mocked storage removal.

### Tests
- `sh run-be-ut.sh --run --filter
"BlockFileCacheTest.clear_file_cache_sync*:BlockFileCacheTest.clear_retains_meta_directory_and_clears_meta_entries"`

Co-authored-by: gavinchou <gavinchou@apache.org>
@github-actions github-actions Bot requested a review from yiguolei as a code owner June 22, 2026 09:42
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 92.59% (50/54) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 54.15% (20625/38090)
Line Coverage 37.70% (196299/520684)
Region Coverage 34.05% (153413/450571)
Branch Coverage 35.02% (66964/191243)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 92.59% (50/54) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 73.81% (27473/37221)
Line Coverage 57.43% (297601/518181)
Region Coverage 55.23% (250552/453676)
Branch Coverage 56.55% (108307/191537)

@yiguolei yiguolei merged commit b317c8e into branch-4.1 Jun 23, 2026
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants