[Improve](Audit) Auditlog on FE with https enabled#64697
Open
nsivarajan wants to merge 2 commits into
Open
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 29243 ms |
Contributor
TPC-DS: Total hot run time: 173951 ms |
Contributor
ClickBench: Total hot run time: 25.28 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run p0 |
Contributor
Author
|
run external |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run p0 |
Contributor
FE Regression Coverage ReportIncrement line coverage |
1 similar comment
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Problem
When
enable_https=trueandhttp_port=0(HTTP disabled), the built-in audit plugin fails silently on every batch.AuditStreamLoaderhardcodedhttp://127.0.0.1:{http_port}at construction time, so the stream loadURL became
http://127.0.0.1:0— an unreachable address. EveryloadBatch()call threw a connection error, which was swallowed and counted as discarded logs. No crash, no clear error — audit logging simply stopped working.Fix
httpswhenenable_https=true) and port (HttpURLUtil.getHttpPort(), which returnshttps_portwhen HTTPS is enabled).mysql_ssl_default_ca_certificate) to the FE connection when the URL is HTTPS, via a new shared utilityInternalHttpsUtils.getSslContext().instanceof HttpsURLConnection.Also, this serves as preparatory for #60921
Behaviour
enable_https=falsehttp://127.0.0.1:8030http://127.0.0.1:8030— unchangedenable_https=true, http_port=0http://127.0.0.1:0— fails silentlyhttps://127.0.0.1:8050— worksNotes
InternalHttpsUtilsis introduced here as a shared SSL context utility. A follow-up PR will extend it to cover FE-to-FE internal REST communication over HTTPS.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)