[fix](be) Fix concat_ws nullable array handling#64703
Merged
Merged
Conversation
HappenLee
requested review from
924060929,
englefly,
morrySnow and
starocean999
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
### What problem does this PR solve?
Issue Number: N/A
Related PR: N/A
Problem Summary: concat_ws has a BE execution path for a single array argument. When the array column row itself is NULL, the executor still walked the nested array data and could return values from nested storage instead of treating the NULL array row as empty input. Also, if the optimizer rewrite is disabled, multiple array arguments can reach this BE array path and were silently executed using only the first array argument. This change keeps concat_ws return nullability unchanged, skips nested data for NULL array rows, and rejects array-form concat_ws calls unless the executor receives exactly separator plus one array argument.
### Release note
Fix wrong concat_ws results for nullable array inputs and return an error for unsupported multiple-array execution without optimizer rewrite.
### Check List (For Author)
- Test: Regression test and build
- ./build.sh --be
- ./run-regression-test.sh --run --conf /tmp/doris-regression-conf-run-path.groovy -d nereids_function_p0/scalar_function -s nereids_scalar_fn_concat_ws -forceGenOut
- ./run-regression-test.sh --run --conf /tmp/doris-regression-conf-run-path.groovy -d nereids_function_p0/scalar_function -s nereids_scalar_fn_concat_ws
- Behavior changed: Yes. concat_ws skips nested data for NULL array rows, and unsupported multiple-array BE execution now returns INVALID_ARGUMENT instead of silently consuming only the first array.
- Does this need documentation: No
HappenLee
force-pushed
the
fix-concat-ws-null-array
branch
from
870dbc0 to
aa7bf6f
Compare
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 29245 ms |
Contributor
TPC-DS: Total hot run time: 173283 ms |
Contributor
ClickBench: Total hot run time: 25.33 s |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated review completed for PR #64703. I did not find a blocking correctness issue to raise inline.
Critical checkpoint conclusions:
- Goal/test coverage: The PR fixes nullable array-row handling in BE
concat_wsarray mode and adds regression coverage for the default rewritten path, a filtered nullable-array case, and the disabled-rewrite error path. - Scope: The code change is narrowly limited to BE
concat_wsarray execution and the matching regression test/output. - Concurrency/lifecycle/transactions/persistence: Not involved.
- Configuration/session behavior: No new config. The existing
disable_nereids_expression_rulespath was reviewed because the test uses it. - Compatibility/parallel paths: Multi-array
concat_wsremains supported through the normal NereidsCONCATWS_MULTI_ARRAY_TO_ONErewrite. The direct BE multi-array shape previously returned wrong data by ignoring later arrays; this PR turns that unsupported shape into an explicitInvalidArgument. - Error handling: The new BE arity guard returns
Statusthrough the existing function execution path. - Nullability/data correctness: The output remains separator-nullability driven, and NULL array rows now skip nested data and produce the existing Doris empty-string behavior.
- Tests/results/style: The added regression output matches the added queries, uses deterministic ordering where multiple rows are returned, and
git diff --checkis clean. - Performance/observability: No new hot-path concern or observability requirement found for this small branch.
Subagent conclusions:
optimizer-rewrite:OPT-NONE; no optimizer/rewrite candidate was substantiated.tests-session-config: proposedTEST-001about disabledCONCATWS_MULTI_ARRAY_TO_ONE; main review dismissed it with evidence because the disabled-rule direct BE path was already semantically wrong before this PR and now fails explicitly.- Convergence round 1: both live subagents replied
NO_NEW_VALUABLE_FINDINGSfor the same final ledger/comment set.
User focus: No additional user-provided review focus was supplied.
CI note: The listed macOS BE UT failure is from the runner using Java 25 while the job requires JDK 17; compile, Linux BE UT, formatter, CheckStyle, and P0 regression checks shown for the PR are passing or unrelated/pending.
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
BiteTheDDDDt
approved these changes
Jun 23, 2026
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 23, 2026
Problem Summary: concat_ws has a BE execution path for a single array argument. When the array column row itself is NULL, the executor still walked the nested array data and could return values from nested storage instead of treating the NULL array row as empty input. Also, if the optimizer rewrite is disabled, multiple array arguments can reach this BE array path and were silently executed using only the first array argument. This change keeps concat_ws return nullability unchanged, skips nested data for NULL array rows, and rejects array-form concat_ws calls unless the executor receives exactly separator plus one array argument. ### Release note Fix wrong concat_ws results for nullable array inputs and return an error for unsupported multiple-array execution without optimizer rewrite.
yiguolei
pushed a commit
that referenced
this pull request
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Related PR: N/A
Problem Summary: concat_ws has a BE execution path for a single array argument. When the array column row itself is NULL, the executor still walked the nested array data and could return values from nested storage instead of treating the NULL array row as empty input. Also, if the optimizer rewrite is disabled, multiple array arguments can reach this BE array path and were silently executed using only the first array argument. This change keeps concat_ws return nullability unchanged, skips nested data for NULL array rows, and rejects array-form concat_ws calls unless the executor receives exactly separator plus one array argument.
Release note
Fix wrong concat_ws results for nullable array inputs and return an error for unsupported multiple-array execution without optimizer rewrite.
Check List (For Author)