branch-4.1: [fix](regression-test) fix stale nested-type assertions in two_level/three_level_nestedtypes_with_s3data #64706#64707
Merged
Conversation
…three_level_nestedtypes_with_s3data (#64706) ## Summary - `GROUP BY`/`ORDER BY` on plain array/map/struct columns no longer throws (`CheckAfterRewrite` now only blocks Object/Variant/Varbinary types), so the old `errCode = 2 ... must use with specific function ... group by or order by` exception assertions in `two_level_nestedtypes_with_s3data.groovy` / `three_level_nestedtypes_with_s3data.groovy` are stale; removed. - `element_at()` on a struct returns an untyped result that `GROUP BY`/`ORDER BY` and functions like `map_keys()`/`size()` can't accept directly — the most-nested-column checks now `CAST` it to the concrete type at each point of use instead of relying on it implicitly resolving. - Struct `element_at()` out-of-bound access (`-1`/`0`/`1000`) no longer throws `the specified field index out of bound` either; those stale assertions are removed too. - Refreshes `CPUNetworkUtilization_order.out` (brown_p2) to match current output — same class of stale-baseline issue. ## Test plan - [x] Ran `two_level_nestedtypes_with_s3data` and `three_level_nestedtypes_with_s3data` end-to-end with `-forceGenOut` on a branch-4.0 cluster — `All suites success.` - [x] Ran both suites on a master-branch cluster — `two_level_nestedtypes_with_s3data` passes. `three_level_nestedtypes_with_s3data` hits an unrelated master-only BE bug (`[NOT_IMPLEMENTED_ERROR] Method insert_many_dict_data is not supported for TINYINT`) on a plain, untouched `element_at` SELECT — pre-existing, out of scope for this PR. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> https://claude.ai/code/session_01EoF4rikuEzGPKT2ML2WtnM Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
Author
Possible file(s) that should be tracked in LFS detected: 🚨The following file(s) exceeds the file size limit:
Consider using |
yiguolei
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #64706