branch-4.0: [fix](load) respect profile level for writer details #64620#64710
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.0: [fix](load) respect profile level for writer details #64620#64710github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
### What problem does this PR solve? PR #64349 removed the stored RuntimeState from shared DeltaWriterV2 to fix a valid lifetime issue. However, the master change did not move the existing detailed-writer-profile gate to the VTabletWriterV2 call site. As a result, closing tablet writer v2 always passed the operator profile into DeltaWriterV2Map, and DeltaWriterV2/MemTableWriter detailed child profiles were still emitted even when profile_level was 1. Pass the profile only when profile_level is at least 2 so level 1 keeps only merged profile counters as intended.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #64620