Skip to content

[fix](be) Check block column and type pointers#64721

Open
Mryange wants to merge 1 commit into
apache:masterfrom
Mryange:block-null-checks
Open

[fix](be) Check block column and type pointers#64721
Mryange wants to merge 1 commit into
apache:masterfrom
Mryange:block-null-checks

Conversation

@Mryange

@Mryange Mryange commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Add an explicit block check to reject null column or type pointers at operator sink/get_block boundaries, while keeping the existing type compatibility check unchanged.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange

Mryange commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 29619 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ebd2f2fd6f3dae26feb523a95cd72db628d35a6b, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17773	4348	4275	4275
q2	2012	334	192	192
q3	10286	1509	843	843
q4	4679	526	341	341
q5	7530	880	571	571
q6	194	189	146	146
q7	818	852	639	639
q8	9350	1731	1607	1607
q9	5751	4537	4482	4482
q10	6825	1880	1511	1511
q11	453	287	246	246
q12	632	471	300	300
q13	18089	3598	2735	2735
q14	286	275	248	248
q15	q16	808	792	714	714
q17	998	1022	1015	1015
q18	7039	5764	5613	5613
q19	1295	1405	1106	1106
q20	503	413	265	265
q21	6056	2651	2464	2464
q22	464	369	306	306
Total cold run time: 101841 ms
Total hot run time: 29619 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4573	4479	4516	4479
q2	332	381	246	246
q3	4774	5112	4483	4483
q4	2346	2389	1401	1401
q5	4724	4549	4568	4549
q6	398	255	166	166
q7	2461	1917	1631	1631
q8	2842	2419	2456	2419
q9	8912	8523	8397	8397
q10	5187	4982	4434	4434
q11	643	461	442	442
q12	817	823	566	566
q13	3327	3805	2996	2996
q14	310	314	272	272
q15	q16	733	751	648	648
q17	1597	1399	1352	1352
q18	8415	7569	7455	7455
q19	1112	1083	1093	1083
q20	2287	2275	1964	1964
q21	5732	4894	4768	4768
q22	551	482	413	413
Total cold run time: 62073 ms
Total hot run time: 54164 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 172758 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ebd2f2fd6f3dae26feb523a95cd72db628d35a6b, data reload: false

query5	4329	637	488	488
query6	460	185	166	166
query7	4829	565	306	306
query8	366	214	200	200
query9	8734	4059	4045	4045
query10	447	308	260	260
query11	5905	2359	2138	2138
query12	157	105	109	105
query13	1255	592	409	409
query14	6378	5427	5094	5094
query14_1	4440	4357	4375	4357
query15	205	190	177	177
query16	1002	487	446	446
query17	1097	675	551	551
query18	2444	481	338	338
query19	192	183	146	146
query20	113	102	103	102
query21	221	143	113	113
query22	13682	13622	13451	13451
query23	17516	16527	16307	16307
query23_1	16271	16282	16276	16276
query24	7479	1840	1314	1314
query24_1	1330	1310	1330	1310
query25	521	427	387	387
query26	1288	312	164	164
query27	2707	552	342	342
query28	4450	2027	2020	2020
query29	1074	636	476	476
query30	319	241	196	196
query31	1133	1076	944	944
query32	105	59	63	59
query33	521	314	256	256
query34	1196	1148	648	648
query35	765	788	679	679
query36	1379	1393	1205	1205
query37	149	105	92	92
query38	1872	1716	1691	1691
query39	936	921	903	903
query39_1	874	879	871	871
query40	216	123	97	97
query41	63	62	61	61
query42	87	89	85	85
query43	328	330	279	279
query44	1499	773	783	773
query45	193	182	172	172
query46	1078	1215	753	753
query47	2354	2297	2216	2216
query48	400	397	283	283
query49	617	457	339	339
query50	1028	377	255	255
query51	4496	4312	4317	4312
query52	80	82	68	68
query53	246	269	191	191
query54	277	216	195	195
query55	72	69	64	64
query56	230	229	210	210
query57	1436	1389	1324	1324
query58	244	217	227	217
query59	1608	1653	1422	1422
query60	276	240	220	220
query61	155	170	170	170
query62	708	650	586	586
query63	236	194	197	194
query64	2587	835	660	660
query65	4919	4775	4794	4775
query66	1838	481	354	354
query67	29724	29754	29458	29458
query68	3124	1633	898	898
query69	413	310	281	281
query70	1061	947	993	947
query71	294	239	221	221
query72	3074	2829	2266	2266
query73	888	784	446	446
query74	5120	4977	4776	4776
query75	2636	2622	2239	2239
query76	2330	1201	800	800
query77	352	380	285	285
query78	12744	12476	11853	11853
query79	1413	1198	768	768
query80	1284	480	384	384
query81	526	282	240	240
query82	622	155	120	120
query83	313	271	242	242
query84	264	147	113	113
query85	888	506	405	405
query86	428	294	298	294
query87	1827	1836	1738	1738
query88	3767	2806	2783	2783
query89	425	372	331	331
query90	1905	186	221	186
query91	174	167	131	131
query92	61	57	60	57
query93	1635	1505	869	869
query94	700	343	297	297
query95	664	381	444	381
query96	1090	813	341	341
query97	2702	2699	2587	2587
query98	229	206	197	197
query99	1177	1156	1023	1023
Total cold run time: 259610 ms
Total hot run time: 172758 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants