Skip to content

[fix](cloud) Only mark prepare rowsets before recycle #65550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wyxxxcat wants to merge 1 commit into
base: master
Choose a base branch
from
+1,807 −438
Open

[fix](cloud) Only mark prepare rowsets before recycle #65550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cloud/src/meta-service/meta_service_job.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,7 +946,8 @@ void process_compaction_job(MetaServiceCode& code, std::string& msg, std::string

using namespace std::chrono;
int64_t now = duration_cast<seconds>(system_clock::now().time_since_epoch()).count();
if (recorded_compaction->expiration() > 0 && recorded_compaction->expiration() < now) {
if (request->action() != FinishTabletJobRequest::ABORT &&
recorded_compaction->expiration() > 0 && recorded_compaction->expiration() < now) {
code = MetaServiceCode::JOB_EXPIRED;
SS << "expired compaction job, tablet_id=" << tablet_id
<< " job=" << proto_to_json(*recorded_compaction);
Expand Down Expand Up @@ -1544,7 +1545,8 @@ void process_schema_change_job(MetaServiceCode& code, std::string& msg, std::str
auto& recorded_schema_change = recorded_job.schema_change();
using namespace std::chrono;
int64_t now = duration_cast<seconds>(system_clock::now().time_since_epoch()).count();
if (recorded_schema_change.expiration() > 0 && recorded_schema_change.expiration() < now) {
if (request->action() != FinishTabletJobRequest::ABORT &&
recorded_schema_change.expiration() > 0 && recorded_schema_change.expiration() < now) {
code = MetaServiceCode::JOB_EXPIRED;
SS << "expired schema_change job, tablet_id=" << tablet_id
<< " job=" << proto_to_json(recorded_schema_change);
Expand Down
Loading
Loading