Skip to content

[refine](type)use new type dispatch (#56990) - #66762

Merged
yiguolei merged 1 commit into
apache:branch-4.1from
Mryange:branch-4.1-pick-56990
Aug 15, 2026
Merged

[refine](type)use new type dispatch (#56990)#66762
yiguolei merged 1 commit into
apache:branch-4.1from
Mryange:branch-4.1-pick-56990

Conversation

@Mryange

@Mryange Mryange commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

before

        case TYPE_DATE:
        case TYPE_DATETIME:
        case TYPE_DATEV2:
        case TYPE_DATETIMEV2:
        case TYPE_BOOLEAN:
        case TYPE_TINYINT:

now

dispatch_switch_scalar(left_element_type->get_primitive_type(), call));

(cherry picked from commit af9fb9d)

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

before
```
        case TYPE_DATE:
        case TYPE_DATETIME:
        case TYPE_DATEV2:
        case TYPE_DATETIMEV2:
        case TYPE_BOOLEAN:
        case TYPE_TINYINT:
```

now
```
dispatch_switch_scalar(left_element_type->get_primitive_type(), call));
```

(cherry picked from commit af9fb9d)
@Mryange
Mryange requested a review from yiguolei as a code owner August 14, 2026 06:04
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange

Mryange commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 76.74% (66/86) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.02% (30869/41704)
Line Coverage 58.13% (341307/587134)
Region Coverage 54.97% (284315/517232)
Branch Coverage 55.93% (127941/228744)

@yiguolei
yiguolei merged commit 3bfc2b1 into apache:branch-4.1 Aug 15, 2026
29 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants