Skip to content

[fix](row binlog): reject flexible update on row binlog table - #66764

Open
Userwhite wants to merge 1 commit into
apache:masterfrom
Userwhite:fix_binlog_use_count
Open

[fix](row binlog): reject flexible update on row binlog table#66764
Userwhite wants to merge 1 commit into
apache:masterfrom
Userwhite:fix_binlog_use_count

Conversation

@Userwhite

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #65866

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Userwhite

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-H: Total hot run time: 17850 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f7b23ec4fbe34943938e54e1dec1078bd4a65edd, data reload: false

------ Round 1 ----------------------------------
============================================
q1	17573	3022	3018	3018
q2	1919	240	151	151
q3	10432	876	517	517
q4	4668	254	198	198
q5	7690	578	398	398
q6	139	121	98	98
q7	532	524	394	394
q8	9923	955	953	953
q9	4512	2410	2399	2399
q10	6560	889	729	729
q11	445	258	235	235
q12	697	388	321	321
q13	17926	1892	1582	1582
q14	189	151	142	142
q15	q16	455	406	367	367
q17	1850	877	810	810
q18	3138	2324	2268	2268
q19	1346	949	737	737
q20	668	532	439	439
q21	5442	1856	1968	1856
q22	336	270	238	238
Total cold run time: 96440 ms
Total hot run time: 17850 ms

----- Round 2, with runtime_filter_mode=off -----
============================================
q1	3410	3307	3337	3307
q2	211	217	154	154
q3	2250	2323	2218	2218
q4	1195	1182	889	889
q5	2203	2178	2178	2178
q6	172	126	91	91
q7	1039	955	886	886
q8	1617	1392	1409	1392
q9	3117	3093	3048	3048
q10	1891	1851	1652	1652
q11	355	269	248	248
q12	458	436	343	343
q13	1830	1830	1528	1528
q14	174	183	176	176
q15	q16	395	405	359	359
q17	1035	1032	1023	1023
q18	5062	4504	4856	4504
q19	1268	856	951	856
q20	1027	988	817	817
q21	3701	3099	3239	3099
q22	411	348	322	322
Total cold run time: 32821 ms
Total hot run time: 29090 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
TPC-DS: Total hot run time: 86419 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f7b23ec4fbe34943938e54e1dec1078bd4a65edd, data reload: false

query5	4263	412	326	326
query6	407	153	162	153
query7	4889	462	266	266
query8	292	123	112	112
query9	8659	2908	2938	2908
query10	436	244	206	206
query11	5383	1039	926	926
query12	120	73	70	70
query13	1191	440	333	333
query14	5976	2022	1862	1862
query14_1	1812	1781	1780	1780
query15	171	120	111	111
query16	917	388	386	386
query17	805	481	374	374
query18	2337	340	249	249
query19	168	145	114	114
query20	72	72	74	72
query21	207	119	107	107
query22	5328	5354	5252	5252
query23	7277	6853	6741	6741
query23_1	6863	6791	6673	6673
query24	7302	1119	796	796
query24_1	770	794	790	790
query25	444	307	264	264
query26	1252	252	167	167
query27	2720	450	290	290
query28	4589	1504	1533	1504
query29	945	450	370	370
query30	273	180	150	150
query31	989	685	603	603
query32	101	51	49	49
query33	453	220	182	182
query34	1004	880	486	486
query35	406	396	348	348
query36	556	573	524	524
query37	126	91	75	75
query38	1007	859	799	799
query39	537	563	547	547
query39_1	537	543	498	498
query40	223	126	115	115
query41	60	60	56	56
query42	76	76	76	76
query43	246	254	223	223
query44	1034	577	594	577
query45	116	107	105	105
query46	791	873	542	542
query47	997	975	959	959
query48	331	323	235	235
query49	546	252	200	200
query50	780	347	264	264
query51	8178	8186	8230	8186
query52	74	74	61	61
query53	216	210	159	159
query54	220	202	187	187
query55	76	57	54	54
query56	236	212	216	212
query57	668	636	613	613
query58	242	203	193	193
query59	1112	1113	984	984
query60	269	206	188	188
query61	111	127	111	111
query62	368	216	176	176
query63	181	153	156	153
query64	2756	693	531	531
query65	1606	1580	1550	1550
query66	1781	300	234	234
query67	10085	9771	9988	9771
query68	2768	1228	809	809
query69	343	228	202	202
query70	639	594	593	593
query71	302	254	251	251
query72	2298	1789	1580	1580
query73	631	552	346	346
query74	1570	1225	1167	1167
query75	1250	1157	1014	1014
query76	2282	727	581	581
query77	245	263	226	226
query78	5259	4863	4563	4563
query79	2579	854	601	601
query80	1587	405	332	332
query81	487	194	166	166
query82	625	140	112	112
query83	311	247	233	233
query84	292	124	102	102
query85	830	447	387	387
query86	389	170	167	167
query87	1010	974	900	900
query88	2821	2142	2177	2142
query89	306	232	209	209
query90	1897	144	147	144
query91	150	144	124	124
query92	53	47	44	44
query93	1520	1138	753	753
query94	599	282	198	198
query95	615	348	404	348
query96	834	627	300	300
query97	1111	1088	1079	1079
query98	172	136	129	129
query99	417	348	309	309
Total cold run time: 180598 ms
Total hot run time: 86419 ms

@hello-stephen

Copy link
Copy Markdown
Contributor
ClickBench: Total hot run time: 14.73 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f7b23ec4fbe34943938e54e1dec1078bd4a65edd, data reload: false

query1	0.01	0.01	0.00
query2	0.08	0.06	0.04
query3	0.24	0.12	0.11
query4	1.60	0.10	0.10
query5	0.17	0.16	0.16
query6	1.21	0.60	0.64
query7	0.03	0.01	0.00
query8	0.04	0.03	0.03
query9	0.30	0.22	0.22
query10	0.36	0.34	0.35
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.30	0.32	0.31
query14	0.47	0.48	0.47
query15	0.36	0.36	0.35
query16	0.21	0.24	0.23
query17	0.70	0.67	0.73
query18	0.17	0.16	0.17
query19	1.27	1.20	1.18
query20	0.02	0.01	0.01
query21	15.43	0.16	0.12
query22	5.04	0.04	0.04
query23	16.17	0.25	0.10
query24	3.02	0.32	0.26
query25	0.10	0.04	0.04
query26	0.74	0.16	0.13
query27	0.04	0.04	0.03
query28	3.62	0.58	0.29
query29	12.44	3.16	2.52
query30	0.26	0.11	0.12
query31	2.76	0.38	0.17
query32	3.50	0.32	0.22
query33	1.35	1.52	1.47
query34	15.41	2.25	1.79
query35	1.79	1.81	1.75
query36	0.46	0.30	0.28
query37	0.06	0.04	0.03
query38	0.04	0.02	0.02
query39	0.03	0.03	0.02
query40	0.12	0.07	0.08
query41	0.07	0.02	0.02
query42	0.03	0.02	0.03
query43	0.03	0.03	0.02
Total cold run time: 90.35 s
Total hot run time: 14.73 s

@hello-stephen

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/104) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug](High) Flexible Partial Update fails with ROW binlog due to illegal partial update block columns

2 participants