cm.json: Improve Configurator specification conformance - #548
Open
wilx wants to merge 13 commits into
Open
Conversation
Follow OSGi Compendium 8.1.0, Configurator Specification §150.3.4.
Follow OSGi Compendium 8.1.0, Configurator Specification §150.3.1.
Follow OSGi Compendium 8.1.0, Configurator Specification §150.3.1.
Follow OSGi Compendium 8.1.0, Configurator Specification §150.3.1.
Follow OSGi Compendium 8.1.0, Configurator Specification §150.3.3.
Contributor
|
would you be so nice and test to the osgi tck? |
Contributor
Author
|
I have created https://github.com/wilx/felix-configurator-tck project to test against the test in OSGi TCK that exercise it. The branch passes. If this is what you meant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
cm.jsonto Felix parent 9 and tightens its handling of OSGi Configurator JSON resources.The changes:
String[]as required by Configurator §150.3.4;:configurator:resource-version,:configurator:symbolic-name, and:configurator:versionaccording to §150.3.1, including metadata supplied in bundle resources;The downstream Configurator module is also updated to Felix parent 9 and from
org.apache.felix.cm.json2.0.0 to this branch's 2.0.9-SNAPSHOT. This makes its Java 17 build use the currentcm.jsonimplementation.The metadata work intentionally does not change how PID-level
:configurator:properties are retained when no property handler is installed; that can be addressed separately with an API design suitable for round-tripping.Validation on Java 17:
Results:
cm.json: 60 tests, 0 failures/errors; bundle baseline, RAT, and legal-file checks pass.