FINERACT-2719: Add submittedOnDateTime to journal entry responses - #6195
FINERACT-2719: Add submittedOnDateTime to journal entry responses#6195Samer-Melhem-FOO wants to merge 3 commits into
Conversation
adamsaghy
left a comment
There was a problem hiding this comment.
I see no benefit of adding this field. If you want to have a sorted list, feel free to sort by created date time / and return that...
The benefit isn't sorting — it's the displayed value itself.
|
Disclose the created date and time, but there’s no need to introduce a new field when one already exists with the necessary data. |
Description
The Journal Entries API only returns
submittedOnDate(date-only), so any UI reading it always shows a time of00:00:00, even though the journal entry's actual creation timestamp is stored inacc_gl_journal_entry.created_on_utc.This adds a new optional
submittedOnDateTimefield toJournalEntryData(Fineract-style[year, month, day, hour, minute, second]array), sourced fromcreated_on_utcinJournalEntryReadPlatformServiceImpl.submittedOnDateis left unchanged for backward compatibility.JIRA: https://issues.apache.org/jira/browse/FINERACT-2719
Checklist
Note: no existing unit/integration test covers
JournalEntryReadPlatformServiceImpl's row-mapping logic (it's a plain JDBCRowMapper, not easily unit-testable in isolation), so none were added — happy to add integration-test coverage if a reviewer points to the right harness for it.