Remove dead code block in TellerWritePlatformServiceJpaImpl - #6204
Open
prajakta128 wants to merge 1 commit into
Open
Remove dead code block in TellerWritePlatformServiceJpaImpl#6204prajakta128 wants to merge 1 commit into
prajakta128 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes an unreachable/no-op code block inside
doTransactionForCashier()inTellerWritePlatformServiceJpaImpl.java.Why
The block read an
entityTypeparameter from the request and branched on its value ("loan account", "savings account", "client"), but every branch was either empty or entirely commented-out code.entityTypewas never referenced again anywhere else in the method or the file, so the block had zero effect on runtime behavior. The original author had already flagged it themselves:This PR simply deletes that block. No behavior change.
Why no JIRA ticket
Per CONTRIBUTING.md, a JIRA ticket isn't required for changes that are "truly trivial." This is a straightforward dead-code removal with no functional impact, so I've opened this PR directly.
Checklist
entityTypeis unused elsewhere in the file