FINERACT-2736: Remove unused FineractEntityAccess (createEntityAccess/addNewEntityAccess dead since 2014/2016, no callers, no test coverage)

[AshharAhmadKhan]

Description

createEntityAccess(JsonCommand command) has been an empty stub returning null since the file was first created in 9d11434ee7 (Dec 6 2014). There is no API route, CommandWrapperBuilder method, permission record, or command handler for it anywhere in the codebase, and there never has been.

addNewEntityAccess(...) was implemented from the start and did have one caller, FineractEntityAccessUtil.checkConfigurationAndAddProductResrictionsForUserOffice(...). That changed in 66f8d7ce43 (June 9 2016), which rewrote the caller to call fineractEntityToEntityMappingRepository.save(...) directly instead, bypassing the write service entirely. Since then addNewEntityAccess has had zero callers.

Alongside these two methods, the underlying FineractEntityAccess domain object, its repository, its repository wrapper, and the m_entity_to_entity_access table are only ever referenced from inside these two dead methods. Nothing else touches them.

The live access control path, FineractEntityAccessUtil, used by Charges, Loan Products, and Savings Products, reads from m_entity_to_entity_mapping via FineractEntityAccessReadServiceImpl. This is a separate table from m_entity_to_entity_access. createEntityToEntityMapping, updateEntityToEntityMapping, and deleteEntityToEntityMapping stay exactly as they are and are not touched by this change.

m_entity_to_entity_access has 0 rows in load_sample_data.sql and the project's generated schema docs list it at 0 rows as well.

Changes made

• Deleted FineractEntityAccess.java (domain)
• Deleted FineractEntityAccessRepository.java
• Deleted FineractEntityAccessRepositoryWrapper.java
• Deleted FineractEntityAccessData.java
• Deleted FineractEntityAccessConstants.java
• Deleted FineractEntityAccessConfigurationException.java
• Removed createEntityAccess and addNewEntityAccess from FineractEntityAccessWriteService.java and FineractEntityAccessWriteServiceImpl.java, along with the now-unused entityAccessRepository field, constructor param, and dead imports
• Removed the commented-out updateEntityAccess/removeEntityAccess stubs from the interface
• Added 0243_remove_unused_entity_access.xml, a Liquibase changeset that drops m_entity_to_entity_access
• Removed the m_entity_to_entity_access table definition and sample data block from barebones_db.sql and load_sample_data.sql

Verification

• Full-repo grep across .java, .xml, .sql for FineractEntityAccess, FineractEntityAccessRepository, FineractEntityAccessRepositoryWrapper, FineractEntityAccessData, FineractEntityAccessConfigurationException, and FineractEntityAccessConstants. No stragglers, all hits excluded as still-live (FineractEntityAccessType, FineractEntityAccessNotFoundException, FineractEntityAccessUtil, FineractEntityAccessReadService)
• No reference to either method in fineract-client or fineract-client-feign, no OpenAPI/swagger entry for createEntityAccess
• Test file grep across the repo. No results, no test references either method or class

Discussed on the dev mailing list first: [DISCUSS] ENTITYACCESS | createEntityAccess never implemented since 2014

Ticket: FINERACT-2736

[AshharAhmadKhan]

@adamsaghy please trigger checks whenever possible, thanks a lot ! :)

[galovics]

The PR title says "no callers, no test coverage" but I checked on develop before trusting that - this breaks the build.

// FineractEntityAccessUtil.java (NOT touched by this PR, package org.apache.fineract.infrastructure.entityaccess.service)
private final FineractEntityAccessWriteService fineractEntityAccessWriteService;  // <- deleted by this PR
private final FineractEntityAccessReadService fineractEntityAccessReadService;

FineractEntityAccessUtil is a live @Service with FineractEntityAccessWriteService as a required constructor param, and it's actively wired into SavingsProductWritePlatformServiceJpaRepositoryImpl, ChargeWritePlatformServiceJpaRepositoryImpl, LoanProductWritePlatformServiceJpaRepositoryImpl, and LoanApplicationValidator - this is the "office specific products" access-control feature (the thing behind office-specific-products-enabled). Deleting FineractEntityAccessWriteService breaks FineractEntityAccessUtil's constructor - this doesn't compile, or at minimum fails Spring context startup.

The two-method claim in the title ("createEntityAccess/addNewEntityAccess dead since 2014/2016") might be true for those specific methods, but the PR deletes the whole interface/impl, not just the dead methods. Can we keep FineractEntityAccessWriteService/FineractEntityAccessReadService and only remove the genuinely dead methods (and the table drop needs the same scrutiny)?

[AshharAhmadKhan]

Hi @galovics , thanks for taking a close look at this, but I think the diff is being misread here.

FineractEntityAccessWriteService.java isn't deleted. It only lost two methods: createEntityAccess and addNewEntityAccess, plus the commented out stub block. createEntityToEntityMapping, updateEntityToEntityMapping, and deleteEntityToEntityMapping are all still declared in the interface, untouched.

FineractEntityAccessUtil.java isn't touched by this PR at all, zero diff. So the fineractEntityAccessWriteService field you highlighted is exactly the same before and after. Since the interface still exists, Spring still has a concrete type to inject there. Nothing in that constructor breaks.

I also checked whether FineractEntityAccessUtil actually calls anything on that field. It doesn't. It's declared, injected, and assigned, but never invoked anywhere in the class. So even setting the deletion question aside, this dependency was already dead weight before the PR.

That also lines up with the CI results on this PR. build-core and all the integration shards spin up the full Spring context, and they're passing. If the constructor were actually broken, that wouldn't be possible.

Let me know if I'm missing something on your end though, always good to double check before merging something like this.