FINERACT-2737: Return collateral name, unit price and percentage on l… - #6226
Open
rymghosn wants to merge 1 commit into
Open
FINERACT-2737: Return collateral name, unit price and percentage on l…#6226rymghosn wants to merge 1 commit into
rymghosn wants to merge 1 commit into
Conversation
…oan collateral responses Loan collateral responses only exposed quantity/total/totalCollateral, missing the name, unit price, and percentage-to-base fields already returned for collateral at the client level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loan collateral responses previously exposed only the collateral quantity and calculated values (
quantity,total, andtotalCollateral), while omitting collateral metadata that is already available in the client collateral API.This change adds the following fields to the loan collateral response:
name– the collateral type nameunitPrice– the base price per unitpctToBase– the percentage applied to the base price when calculating the collateral valueThis aligns the loan collateral API with the client collateral API, provides a consistent representation of collateral data across endpoints, and removes the need for clients to make additional API calls to retrieve collateral type and pricing information.
PR:(https://issues.apache.org/jira/browse/FINERACT-2737)