[FLINK-37485][starrocks] Add support for TIME type#4253
Merged
lvyanquan merged 1 commit intoapache:masterfrom Mar 3, 2026
Merged
[FLINK-37485][starrocks] Add support for TIME type#4253lvyanquan merged 1 commit intoapache:masterfrom
lvyanquan merged 1 commit intoapache:masterfrom
Conversation
github-actions
bot
added
docs
Hisoka-X
force-pushed
the
starrocks-time
branch
from
6ab2fce to
c06d3b6
Compare
yuxiqian
reviewed
Feb 4, 2026
...r-starrocks/src/main/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksUtils.java
Outdated
Show resolved
Hide resolved
Hisoka-X
force-pushed
the
starrocks-time
branch
from
c06d3b6 to
b4cd7dd
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds end-to-end support for the CDC TIME type in the StarRocks pipeline connector by mapping it to a compatible StarRocks type and validating behavior through unit/integration tests, alongside related documentation and test-stability improvements.
Changes:
- Add
TIMEschema + serialization handling for StarRocks (mapped toVARCHAR). - Extend StarRocks connector tests to cover
TIMEcreation, evolution, and serialization. - Update StarRocks connector docs (option types/ranges, new metric option, TIME mapping) and improve Fluss IT test readiness.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/main/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksUtils.java | Implements TIME value formatting and maps TimeType to StarRocks VARCHAR with computed length. |
| flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/test/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksMetadataApplierTest.java | Adds unit tests for TIME column mapping and schema evolution. |
| flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/test/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksMetadataApplierITCase.java | Enables TIME in StarRocks datatype IT coverage and validates mapped schema output. |
| flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/test/java/org/apache/flink/cdc/connectors/starrocks/sink/EventRecordSerializationSchemaTest.java | Adds serialization tests for TIME values (precision, evolution, nulls, boundaries). |
| flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-fluss/src/test/java/org/apache/flink/cdc/connectors/fluss/FlussPipelineITCase.java | Adds a cluster readiness wait to reduce flakiness in Fluss pipeline ITs. |
| docs/content/docs/connectors/pipeline-connectors/starrocks.md | Updates option types, adds metric option, and documents TIME-to-VARCHAR mapping. |
| docs/content.zh/docs/connectors/pipeline-connectors/starrocks.md | Same as above for Chinese docs, including corrected timeout range. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
docs/content.zh/docs/connectors/pipeline-connectors/starrocks.md
Outdated
Show resolved
Hide resolved
...c/test/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksMetadataApplierTest.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/flink/cdc/connectors/starrocks/sink/EventRecordSerializationSchemaTest.java
Outdated
Show resolved
Hide resolved
...connector-fluss/src/test/java/org/apache/flink/cdc/connectors/fluss/FlussPipelineITCase.java
Show resolved
Hide resolved
...r-starrocks/src/main/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksUtils.java
Show resolved
Hide resolved
yuxiqian
approved these changes
Feb 28, 2026
Member
yuxiqian
left a comment
yuxiqian
left a comment
There was a problem hiding this comment.
Looks good. Would you like to split changes into commits and rebase this to latest master?
Soft ping @lvyanquan for another look.
Hisoka-X
force-pushed
the
starrocks-time
branch
from
8deca1f to
91f807e
Compare
Member
Author
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This close https://issues.apache.org/jira/browse/FLINK-37485
This pull request adds comprehensive support for the SQL
TIMEtype (with and without precision) in the StarRocks pipeline connector, including serialization, schema evolution, and documentation updates. It also corrects documentation for timeout parameter types and value ranges, and introduces a new configuration for histogram metric window size.