[chore][test] Fix flaky postgres pipeline test case#4293
Merged
lvyanquan merged 2 commits intoapache:masterfrom Mar 4, 2026
Merged
[chore][test] Fix flaky postgres pipeline test case#4293lvyanquan merged 2 commits intoapache:masterfrom
lvyanquan merged 2 commits intoapache:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses flakiness in the Postgres pipeline IT case testDatabaseNameWithHyphenEndToEnd by switching away from executeAndCollect() toward an async job execution + explicit collection and cancellation flow, aiming to ensure the replication slot is released before cleanup.
Changes:
- Replaced
executeAndCollect()with aCollectResultIterator-based collector setup for deterministic event collection. - Executes the streaming job asynchronously and explicitly cancels it during cleanup to release the replication slot.
- Adjusted cleanup ordering to drop the replication slot and database after job cancellation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...rc/test/java/org/apache/flink/cdc/connectors/postgres/source/PostgresPipelineITCaseTest.java
Show resolved
Hide resolved
...rc/test/java/org/apache/flink/cdc/connectors/postgres/source/PostgresPipelineITCaseTest.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/apache/flink/cdc/connectors/postgres/source/PostgresPipelineITCaseTest.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flaky test case testDatabaseNameWithHyphenEndToEnd. Please refer https://github.com/apache/flink-cdc/actions/runs/22517874846/job/65238342570