[FLINK-34195][python] Use python3 as the default Python executable#28450
Draft
lh0156 wants to merge 1 commit into
Draft
[FLINK-34195][python] Use python3 as the default Python executable#28450lh0156 wants to merge 1 commit into
lh0156 wants to merge 1 commit into
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request updates PyFlink's default Python executable from
pythontopython3on non-Windows environments.PyFlink requires Python 3.9+, but
pythonmay resolve to Python 2 or may not exist on systems where Python 3 is installed aspython3. Usingpython3as the default aligns the runtime defaults, shell script defaults, and documentation with the supported Python versions.Brief change log
python.executableandpython.client.executabledefaults topython3.PythonEnvUtilson non-Windows environments topython3.python3.python3.PythonEnvUtilsdefault environment.Verifying this change
This change added tests and can be verified as follows:
PythonOptionsTestfor the defaultpython.executableandpython.client.executablevalues.PythonEnvUtilsTestto expectpython3as the non-Windows default executable while keeping the Windows default aspython.exe.bash -n flink-python/bin/pyflink-shell.sh.bash -n flink-python/pyflink/bin/pyflink-udf-runner.sh.git diff --check.pythondefaults and Python 3.8 wording were not left behind.I also attempted to run:
./mvnw -pl flink-python -am -Dtest=PythonEnvUtilsTest,PythonOptionsTest -Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false -DskipITs -Dfast testThe local reactor build had to be stopped before reaching
flink-pythonbecause the machine had 249 MiB of free disk space remaining while Maven was still compiling upstream reactor dependencies.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Codex (GPT-5)