[FLINK-38918][PyFlink] Support per cluster offset for DynamicKafkaSource in pyflink#28458
Open
KenanAdel wants to merge 7 commits into
Open
[FLINK-38918][PyFlink] Support per cluster offset for DynamicKafkaSource in pyflink#28458KenanAdel wants to merge 7 commits into
KenanAdel wants to merge 7 commits into
Conversation
3773a30 to
f90bb1f
Compare
…s in DynamicKafkaSource
Author
|
@flinkbot run azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR adds support for per-cluster starting and stopping offset initializers in PyFlink's
DynamicKafkaSource, aligning the Python API with the underlying Java implementation introduced in FLINK-38876.Brief change log
ClusterMetadataandSingleClusterTopicMetadataServiceconstructors indynamic_kafka.pyto accept optionalstarting_offsets_initializerandstopping_offsets_initializer._j_initializer.test_dynamic_kafka.pyto verify offset forwarding and ensure backward compatibility when offsets are not provided.Verifying this change
This change is covered by the following newly added unit tests in
test_dynamic_kafka.py:test_single_cluster_metadata_service_with_offsetstest_single_cluster_metadata_service_default_offsetstest_cluster_metadata_with_offsets