GEODE-10534: Fix Deprecated APIs in Support Modules (geode-management, geode-serialization, geode-deployment-legacy, geode-web-api)#7983
Conversation
geode-management RestTemplateClusterManagementServiceTransport.java
○ Update RestTemplateClusterManagementServiceTransport to remove deprecated API usage
○ Replaced deprecated SSLConnectionSocketFactory with DefaultClientTlsStrategy and setSSLSocketFactory with setTlsSocketStrategy
Issue 1.2: Apache Commons Lang StringUtils
Index.java
Updated removeStart with string manipulation code
Module 2: geode-serialization
DSFIDSerializerImpl.java
Updated deprecated getProxyClass with newProxyInstance with a no-op handler
Module 3: geode-deployment-legacy
LegacyClasspathServiceImpl.java
Refactor proxy class creation to avoid deprecated Proxy.getProxyClass usage
Replaced usage of deprecated Proxy.getProxyClass with Proxy.newProxyInstance to obtain proxy class
Module 4: geode-web-api
SwaggerConfig.java
No changes, can be updated when we move to Spring Framework 6.2+ with UrlHandlerFilter
fixed space format issue
|
@kaajaln2, thanks for the update. I reviewed the log errors and they are not related to your fix. Moving the PR to Under Review. |
There was a problem hiding this comment.
@kaajaln2 , Could you please share your reasoning behind these comments? Thanks.
There was a problem hiding this comment.
@JinwooHwang For the deprecated method parser.setMatchOptionalTrailingSeparator(), I think we can wait until we upgrade to Spring 6.2+ and then switch to URLHandlerFilter
There was a problem hiding this comment.
@kaajaln2 , Could you please elaborate why you chose to return null on line 242? Thanks.
There was a problem hiding this comment.
@JinwooHwang Since we are just retrieving the proxy class and no other behavior, the handler is a no-op. I had to add the handler in order to use non-deprecated method.
Module 1: geode-management
RestTemplateClusterManagementServiceTransport.java
- Update RestTemplateClusterManagementServiceTransport to remove deprecated API usage
- Replaced deprecated SSLConnectionSocketFactory with DefaultClientTlsStrategy and setSSLSocketFactory with setTlsSocketStrategy
Issue 1.2: Apache Commons Lang StringUtils
Index.java
- Updated removeStart with string manipulation code
Module 2: geode-serialization
DSFIDSerializerImpl.java
- Updated deprecated getProxyClass with newProxyInstance with a no-op handler
Module 3: geode-deployment-legacy
LegacyClasspathServiceImpl.java
- Refactor proxy class creation to avoid deprecated Proxy.getProxyClass usage
- Replaced usage of deprecated Proxy.getProxyClass with Proxy.newProxyInstance to obtain proxy class
Module 4: geode-web-api
SwaggerConfig.java
- No changes, can be updated when we move to Spring Framework 6.2+ with UrlHandlerFilter
For all changes, please confirm:
develop)?gradlew buildrun cleanly?