Skip to content

Fix NPE in HelixTaskExecutor.reset() when a task completes during shutdown #3168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jackie-Jiang wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix NPE in HelixTaskExecutor.reset() when a task completes during shutdown #3168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,10 +738,11 @@ synchronized void reset() {
// this is a potential area to improve. https://github.com/apache/helix/issues/1245

StringBuilder sb = new StringBuilder();
// Log all tasks that fail to terminate
for (String taskId : _taskMap.keySet()) {
MessageTaskInfo info = _taskMap.get(taskId);
sb.append("Task: " + taskId + " fails to terminate. Message: " + info._task.getMessage() + "\n");
// Log all tasks that fail to terminate. Iterate entrySet() because each entry is read atomically: a task
// completing concurrently removes itself from the map, so keySet() + get() could observe a null value and NPE.
for (Map.Entry<String, MessageTaskInfo> entry : _taskMap.entrySet()) {
sb.append(
"Task: " + entry.getKey() + " fails to terminate. Message: " + entry.getValue()._task.getMessage() + "\n");
}

LOG.info(sb.toString());
Expand Down
Loading