fix(store): refresh gRPC channels after address changes - #3130
Open
bitflicker64 wants to merge 1 commit into
Open
fix(store): refresh gRPC channels after address changes#3130bitflicker64 wants to merge 1 commit into
bitflicker64 wants to merge 1 commit into
Conversation
9 tasks
Refresh cached channel pools when a Store target resolves to a new address. Rebuild stale blocking and async stub pools, and guard concurrent resolution and publication races. Fixes apache#3124
bitflicker64
force-pushed
the
fix/hstore-channel-refresh-3124
branch
from
July 30, 2026 13:21
218b681 to
26218cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
HStore caches gRPC channels and blocking/asynchronous stubs by Store target.
When a stable target resolves to a different address, those pools can retain the
failed transport indefinitely even though the replacement Store is reachable.
This is the channel-lifecycle half of #3124. Complete recovery behind a stable
DNS name still requires the finite positive DNS TTL from #3126; this patch does
not bypass an indefinitely stale JVM DNS cache.
Main Changes
channel.
changes or when an initially unresolved target first resolves.
belong to the current pool.
cannot replace or return retired channels.
Store cluster.
The validated implementation was developed through commits
bf9086ee,4dd41233,26b333ab, andc71c77a0.Verifying these changes
mvn test -pl hugegraph-store/hg-store-test -am -Dtest=AbstractGrpcClientTest -Dsurefire.failIfNoSpecifiedTests=false: 4 distinct tests passed with 0 failures, errors, or skips on Java 11.mvn test -pl hugegraph-store/hg-store-test -am -P store-client-test -Dsurefire.failIfNoSpecifiedTests=false: the refresh-only client suite ran 4 tests with 0 failures, errors, or skips on Java 11.mvn editorconfig:format: passed with 0 files changed.mvn clean compile -Dmaven.javadoc.skip=true: passed across all 38 reactor modules on Java 11.Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need