feat: support expire snapshots #490
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgtmac
reviewed
Jan 6, 2026
| return new_schema_id; | ||
| } | ||
|
|
||
| Status TableMetadataBuilder::Impl::SetRef(const std::string& name, |
Member
There was a problem hiding this comment.
#408 is adding SetRef and AddSnapshot. Perhaps we should wait for it to be merged and leave them as not implemented for now?
Contributor
Author
There was a problem hiding this comment.
Agree. This pr depends on the implement of SetRef and AddSnapshot, I will rebase code after #408 to avoiding conflict
| return {}; | ||
| } | ||
|
|
||
| Status TableMetadataBuilder::Impl::RemoveRef(const std::string& name) { |
Member
There was a problem hiding this comment.
This does not align with the Java impl:
public Builder removeRef(String name) {
if (SnapshotRef.MAIN_BRANCH.equals(name)) {
this.currentSnapshotId = -1;
}
SnapshotRef ref = refs.remove(name);
if (ref != null) {
changes.add(new MetadataUpdate.RemoveSnapshotRef(name));
}
return this;
}| return {}; | ||
| } | ||
|
|
||
| Status TableMetadataBuilder::Impl::RemoveSnapshots( |
Member
There was a problem hiding this comment.
This does not align with the Java imp either.
wgtmac
requested changes
Jan 6, 2026
| } | ||
|
|
||
| ExpireSnapshots& ExpireSnapshots::CleanupLevel(enum CleanupLevel level) { | ||
| cleanup_level_ = level; |
Member
There was a problem hiding this comment.
Java impl has this check:
Preconditions.checkArgument(
cleanExpiredFiles || level == CleanupLevel.NONE,
"Cannot set cleanupLevel to %s when cleanExpiredFiles was explicitly set to false",
level);
Contributor
Author
There was a problem hiding this comment.
cleanExpiredFiles was deprecated in lastest version
dongxiao1198
force-pushed
the
expire_snapshots
branch
from
3b03dba to
42d7071
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part1 implements to support expire snapshots described in issue #364.
1 Add ExpireSnapshot in TableMetadataBuilder,Table,Transaction...
2 Add basic UT for TableMetadataBuilder and E2E with in memory catalog
TODO: FileCleanupStrategy and file recycle need another independent PR to do，and need more UT after all part finished.