Skip to content

Fix residual NotNaN for null partition values #3689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinjqliu merged 2 commits into from
Aug 21, 2026
Merged

Fix residual NotNaN for null partition values #3689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3efd6d7
Fix residual NotNaN for null partition values
BharatDeva Jul 21, 2026
bbeaee9
test: cover residual NotNaN with NaN values
kevinjqliu Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pyiceberg/expressions/visitors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1874,10 +1874,10 @@ def visit_is_nan(self, term: BoundTerm) -> BooleanExpression:

def visit_not_nan(self, term: BoundTerm) -> BooleanExpression:
val = term.eval(self.struct)
if isinstance(val, SupportsFloat) and not math.isnan(val):
return self.visit_true()
else:
if isinstance(val, SupportsFloat) and math.isnan(val):
return self.visit_false()
else:
return self.visit_true()
Comment on lines +1877 to +1880

@kevinjqliu kevinjqliu Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

previously for None, isinstance(None, SupportsFloat) is false, so it returned AlwaysFalse().


def visit_less_than(self, term: BoundTerm, literal: LiteralValue) -> BooleanExpression:
if term.eval(self.struct) < literal.value:
Expand Down
6 changes: 6 additions & 0 deletions tests/expressions/test_residual_evaluator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,9 @@ def test_is_not_nan() -> None:
res_eval = residual_evaluator_of(spec=spec, expr=predicate, case_sensitive=True, schema=schema)

residual = res_eval.residual_for(Record(None))
assert residual == AlwaysTrue()

residual = res_eval.residual_for(Record(float("nan")))
Comment on lines 213 to +216

@kevinjqliu kevinjqliu Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None is now true.
NaN is now false.

assert residual == AlwaysFalse()

residual = res_eval.residual_for(Record(2))
Expand All @@ -223,6 +226,9 @@ def test_is_not_nan() -> None:
res_eval = residual_evaluator_of(spec=spec, expr=predicate, case_sensitive=True, schema=schema)

residual = res_eval.residual_for(Record(None))
assert residual == AlwaysTrue()

residual = res_eval.residual_for(Record(float("nan")))
assert residual == AlwaysFalse()

residual = res_eval.residual_for(Record(2))
Expand Down