tests: ensure type consistency per spec - #3719
Open
jayceslesar wants to merge 2 commits into
Open
Conversation
| StatsAggregator(iceberg_type, physical_type_string) | ||
|
|
||
|
|
||
| def test_iceberg_types_write_spec_compliant_parquet_types(tmp_path: Path) -> None: |
Collaborator
There was a problem hiding this comment.
You've got a test below to fail if pyarrow introduces any types not in the test. Can you do something similar if we introduce a type and it's not in the list?
| missing = { | ||
| name | ||
| for name in dir(pa.lib) | ||
| if name.startswith("Type_") and name not in unconstructible and getattr(pa.lib, name) not in covered_type_ids |
Collaborator
There was a problem hiding this comment.
I really love the idea of this test. I worry that this is going to be too brittle and relies on the Pyarrow directory / file structure remaining as-is.
Contributor
Author
There was a problem hiding this comment.
what if we just remove this test? i dont really like it no matter how its implemented hahahaha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3714