DRAFT/Experiment to see how encrypted reads might look#2042
DRAFT/Experiment to see how encrypted reads might look#2042xanderbailey wants to merge 8 commits intoapache:mainfrom
Conversation
| .with_preload_page_index(should_load_page_index); | ||
|
|
||
| // Check if file is encrypted but encryption feature is not enabled | ||
| #[cfg(not(feature = "encryption"))] |
There was a problem hiding this comment.
Not sure if we want this or not...
| let result = std::thread::scope(|s| { | ||
| s.spawn(|| { | ||
| handle.block_on(async move { | ||
| encryption_manager.prepare_decryption(&key_metadata).await |
There was a problem hiding this comment.
prepare_decryption is async so we need the tokio Handle here to call the async function in a sync context...
| let result = std::thread::scope(|s| { | ||
| s.spawn(|| { | ||
| handle.block_on(async move { | ||
| encryption_manager.prepare_decryption(&key_metadata).await |
There was a problem hiding this comment.
prepare_decryption is async so we need the tokio Handle here to call the async function in a sync context...
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
1 participant
Which issue does this PR close?
I just wanted to experiment to see how it might look to read encrypted manifests, manifest lists and parquet.
Working towards #2034
What changes are included in this PR?
Are these changes tested?